feat/improvements #1

lyz · 2024-07-20T08:47:33Z

lyz commented

2024-07-20 08:47:33 +00:00

feat(Timestamp): add the from_datetime method

To update the current Timestamp instance based on a datetime or date object.

I've also included a set_datetime method to OrgTime

feat: add activate and deactivate methods to TimeRange and OrgTime

I need it in a program I'm making
refactor: Create the Time type hint

I had to move the parse_time and parse_org_time_range below OrgTime
because it used the Time type hint and the Time type hint needed the
other two

style: reformat the code following black

style: Add some type hints and docstrings

style: remove unused imports

tests: Correct some mypy errors

feat(Timestamp): add the from_datetime method To update the current Timestamp instance based on a datetime or date object. I've also included a set_datetime method to OrgTime feat: add activate and deactivate methods to TimeRange and OrgTime I need it in a program I'm making refactor: Create the Time type hint I had to move the parse_time and parse_org_time_range below OrgTime because it used the Time type hint and the Time type hint needed the other two style: reformat the code following black style: Add some type hints and docstrings style: remove unused imports tests: Correct some mypy errors

lyz added 2 commits 2024-07-20 08:47:34 +00:00

Fix implicit link parsing.

Testing / pytest (push) Successful in 1m34s

Details

Testing / mypy (push) Failing after 30s

Details

Testing / stability-extra-test (push) Successful in 24s

Details

4fd29819ea

feat(Timestamp): add the from_datetime method c5cc14f65c

To update the current Timestamp instance based on a datetime or date object.

I've also included a set_datetime method to OrgTime

feat: add activate and deactivate methods to TimeRange and OrgTime

I need it in a program I'm making
refactor: Create the Time type hint

I had to move the parse_time and parse_org_time_range below OrgTime
because it used the Time type hint and the Time type hint needed the
other two

style: reformat the code following black

style: Add some type hints and docstrings

style: remove unused imports

tests: Correct some mypy errors

lyz added 2 commits 2024-07-20 08:49:18 +00:00

Merge branch 'develop' of ssh://code.codigoparallevar.com:2022/lyz/org-rw into develop 921495fca8

Merge branch 'develop' into feat/improvements 694f3f59e2

lyz added 1 commit 2024-07-20 09:15:42 +00:00

feat: add the scheduled, deadline and closed arguments to Headline init f640521b56

style: Improve the type hints of Time

When reading them it's more natural to read Optional[Time] than to
assume that None is part of the Union in Time

lyz added 1 commit 2024-07-20 09:38:58 +00:00

feat: initialise a Timestamp from a datetime object be68d10d7a

lyz added 1 commit 2024-07-20 09:42:00 +00:00

feat: Set the default Timestamp active to True ff841f82f0

That way you don't need to specify it if you don't want

kenkeiras approved these changes 2024-07-20 15:53:40 +00:00

Dismissed

kenkeiras left a comment

Looks great! I think we can merge it. I'll try to make some changes after that to the repetition code so we can specify which states are valid/understood by the usual emacs setup.

tests/test_timestamp.py Outdated

						
				@ -0,0 +44,4 @@

				        hour=15,

				        minute=45,

				        dow="Saturday",

				        repetition="Weekly",

kenkeiras commented

2024-07-20 15:50:59 +00:00

In practice, the repetition patterns are the ones for Org-mode, which you can see as part of BASE_TIME_STAMP_RE.

They generally match the regexp: (?P<repetition> (?P<rep_mark>(\+|\+\+|\.\+|-|--))(?P<rep_value>\d+)(?P<rep_unit>[hdwmy]))

For example:
+1d, ++1w or +.1m

See: https://orgmode.org/manual/Repeated-tasks.html

In practice, the repetition patterns are the ones for Org-mode, which you can see as part of `BASE_TIME_STAMP_RE`. They generally match the regexp: `(?P<repetition> (?P<rep_mark>(\+|\+\+|\.\+|-|--))(?P<rep_value>\d+)(?P<rep_unit>[hdwmy]))` For example: `+1d`, `++1w` or `+.1m` See: https://orgmode.org/manual/Repeated-tasks.html

lyz commented

2024-07-26 11:36:51 +00:00

Fixed at 191bb75

Fixed at 191bb75

👍 1

kenkeiras marked this conversation as resolved

kenkeiras added 1 commit 2024-07-20 15:53:57 +00:00

Merge branch 'develop' into feat/improvements cca2a9ec1c

lyz added 2 commits 2024-07-26 11:36:13 +00:00

tests: fix repetition string 191bb753c4

merge upstream 9fea315115

kenkeiras approved these changes 2024-07-29 11:15:23 +00:00